OSDN Git Service

virtio-console: avoid DMA from stack
authorOmar Sandoval <osandov@fb.com>
Wed, 1 Feb 2017 08:02:27 +0000 (00:02 -0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 21 Apr 2017 07:31:24 +0000 (09:31 +0200)
commit86c6667f6a5f6bdb392d8ffbe58fbcbcf6db2704
tree735cdb27c467f3899a5b92e3957063ec31635de8
parentfb00319317c152bf3528df13a54c28bf8c5daa55
virtio-console: avoid DMA from stack

commit c4baad50297d84bde1a7ad45e50c73adae4a2192 upstream.

put_chars() stuffs the buffer it gets into an sg, but that buffer may be
on the stack. This breaks with CONFIG_VMAP_STACK=y (for me, it
manifested as printks getting turned into NUL bytes).

Signed-off-by: Omar Sandoval <osandov@fb.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
Reviewed-by: Amit Shah <amit.shah@redhat.com>
Cc: Ben Hutchings <ben@decadent.org.uk>
Cc: Brad Spengler <spender@grsecurity.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/char/virtio_console.c