OSDN Git Service

scsi: core: Fixup calling convention for scsi_mode_sense()
authorHannes Reinecke <hare@suse.de>
Tue, 27 Apr 2021 08:30:09 +0000 (10:30 +0200)
committerMartin K. Petersen <martin.petersen@oracle.com>
Tue, 1 Jun 2021 02:48:20 +0000 (22:48 -0400)
commit8793613de913e03e7c884f4cc56e350bc716431e
treeecc53ed3e2636d951e3d810b14a656555aafdc02
parent21eccf304b3a16c26fc2878faca4665907a318ec
scsi: core: Fixup calling convention for scsi_mode_sense()

The description for scsi_mode_sense() claims to return the number of valid
bytes on success, which is not what the code does.  Additionally there is
no gain in returning the SCSI status, as everything the callers do is to
check against scsi_result_is_good(), which is what scsi_mode_sense() does
already.  So change the calling convention to return a standard error code
on failure, and 0 on success, and adapt the description and all callers.

Link: https://lore.kernel.org/r/20210427083046.31620-4-hare@suse.de
Reviewed-by: Bart Van Assche <bvanassche@acm.org>
Signed-off-by: Hannes Reinecke <hare@suse.de>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/scsi/scsi_lib.c
drivers/scsi/scsi_transport_sas.c
drivers/scsi/sd.c
drivers/scsi/sr.c