OSDN Git Service

HID: do not call hid_set_drvdata(hdev, NULL) in drivers
authorBenjamin Tissoires <benjamin.tissoires@redhat.com>
Mon, 12 Aug 2019 16:27:39 +0000 (18:27 +0200)
committerBenjamin Tissoires <benjamin.tissoires@redhat.com>
Thu, 22 Aug 2019 15:11:58 +0000 (17:11 +0200)
commit87fcb6a69e54527ccaeb5878168cccdba9f6b6ae
treee0aacd9f60504384cc942f0bdbb37ae9c7f04d63
parent15d90b242290f228166ea79ee1cc2db6b31a2143
HID: do not call hid_set_drvdata(hdev, NULL) in drivers

This is a common pattern in the HID drivers to reset the drvdata. Some
do it properly, some do it only in case of failure.

But, this is actually already handled by driver core, so there is no need
to do it manually.

[for hid-sensor-hub.c]
Acked-by: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
[For hid-picolcd_core.c]
Acked-by: Bruno Prémont <bonbons@linux-vserver.org>
Signed-off-by: Benjamin Tissoires <benjamin.tissoires@redhat.com>
drivers/hid/hid-cougar.c
drivers/hid/hid-gfrm.c
drivers/hid/hid-lenovo.c
drivers/hid/hid-picolcd_core.c
drivers/hid/hid-sensor-hub.c