OSDN Git Service

net/smc: receive returns without data
authorKarsten Graul <kgraul@linux.ibm.com>
Thu, 10 Oct 2019 08:16:10 +0000 (10:16 +0200)
committerJakub Kicinski <jakub.kicinski@netronome.com>
Fri, 11 Oct 2019 02:08:41 +0000 (19:08 -0700)
commit882dcfe5a1785c20f45820cbe6fec4b8b647c946
tree7f11be8258d79a3d48af2953b66eb796e2d3651b
parent29ee2701529e1905c0e948688f9688c68c8d4ea4
net/smc: receive returns without data

smc_cdc_rxed_any_close_or_senddone() is used as an end condition for the
receive loop. This conflicts with smc_cdc_msg_recv_action() which could
run in parallel and set the bits checked by
smc_cdc_rxed_any_close_or_senddone() before the receive is processed.
In that case we could return from receive with no data, although data is
available. The same applies to smc_rx_wait().
Fix this by checking for RCV_SHUTDOWN only, which is set in
smc_cdc_msg_recv_action() after the receive was actually processed.

Fixes: 952310ccf2d8 ("smc: receive data from RMBE")
Reviewed-by: Ursula Braun <ubraun@linux.ibm.com>
Signed-off-by: Karsten Graul <kgraul@linux.ibm.com>
Signed-off-by: Jakub Kicinski <jakub.kicinski@netronome.com>
net/smc/smc_rx.c