OSDN Git Service

drm/amd/display: Fix USB4 null pointer dereference in update_psp_stream_config
authorNicholas Kazlauskas <nicholas.kazlauskas@amd.com>
Fri, 17 Dec 2021 19:18:59 +0000 (14:18 -0500)
committerAlex Deucher <alexander.deucher@amd.com>
Tue, 28 Dec 2021 21:03:35 +0000 (16:03 -0500)
commit88eabcb8e6965b38331618f60567dfe92ad3c42c
treeaa0ce770f4a098635b68be07b52165084809c85f
parent4da8b63944a4f4482303c9ad6efb18aa547d4630
drm/amd/display: Fix USB4 null pointer dereference in update_psp_stream_config

[Why]
A porting error on a previous patch left the block of code that
causes the crash from a NULL pointer dereference.

More specifically, we try to access link_enc before it's assigned in
the USB4 case in the following assignment:

config.dio_output_idx = link_enc->transmitter - TRANSMITTER_UNIPHY_A;

[How]
That assignment occurs later depending on the ASIC version. It's only
needed on DCN31 and only after link_enc is already assigned.

Fixes: 986430446c917b ("drm/amd/display: fix a crash on USB4 over C20 PHY")
Reviewed-by: Harry Wentland <harry.wentland@amd.com>
Signed-off-by: Nicholas Kazlauskas <nicholas.kazlauskas@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
drivers/gpu/drm/amd/display/dc/core/dc_link.c