OSDN Git Service

virtiofsd: Disable remote posix locks by default
authorVivek Goyal <vgoyal@redhat.com>
Mon, 27 Jul 2020 16:18:41 +0000 (12:18 -0400)
committerDr. David Alan Gilbert <dgilbert@redhat.com>
Fri, 28 Aug 2020 12:34:52 +0000 (13:34 +0100)
commit88fc107956a5812649e5918e0c092d3f78bb28ad
tree4b8a8b267b539c3303f7e1dcfa5c61c77543e17a
parenta9e80a5f0cdd8e51c266ea0f943f8aafdd0afd13
virtiofsd: Disable remote posix locks by default

Right now we enable remote posix locks by default. That means when guest
does a posix lock it sends request to server (virtiofsd). But currently
we only support non-blocking posix lock and return -EOPNOTSUPP for
blocking version.

This means that existing applications which are doing blocking posix
locks get -EOPNOTSUPP and fail. To avoid this, people have been
running virtiosd with option "-o no_posix_lock". For new users it
is still a surprise and trial and error takes them to this option.

Given posix lock implementation is not complete in virtiofsd, disable
it by default. This means that posix locks will work with-in applications
in a guest but not across guests. Anyway we don't support sharing
filesystem among different guests yet in virtiofs so this should
not lead to any kind of surprise or regression and will make life
little easier for virtiofs users.

Reported-by: Aa Aa <jimbothom@yandex.com>
Suggested-by: Miklos Szeredi <mszeredi@redhat.com>
Signed-off-by: Vivek Goyal <vgoyal@redhat.com>
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
Reviewed-by: Misono Tomohiro <misono.tomohiro@jp.fujitsu.com>
Signed-off-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
docs/tools/virtiofsd.rst
tools/virtiofsd/passthrough_ll.c