OSDN Git Service

regulator: lp8755: Fix notifier mutex lock warning
authorSteve Twiss <stwiss.opensource@diasemi.com>
Tue, 26 Feb 2019 15:32:18 +0000 (15:32 +0000)
committerMark Brown <broonie@kernel.org>
Wed, 13 Mar 2019 15:11:40 +0000 (15:11 +0000)
commit89b2758c192c35068b07766a6830433bfbdc1f44
tree8b48807aac42d4ae96bd383466c3bd2edd13d14a
parent65378de3359d30ebce44762d8b8027f372b5b1c4
regulator: lp8755: Fix notifier mutex lock warning

The mutex for the regulator_dev must be controlled by the caller of
the regulator_notifier_call_chain(), as described in the comment
for that function.

Failure to mutex lock and unlock surrounding the notifier call results
in a kernel WARN_ON_ONCE() which will dump a backtrace for the
regulator_notifier_call_chain() when that function call is first made.
The mutex can be controlled using the regulator_lock/unlock() API.

Fixes: b59320cc5a5e ("regulator: lp8755: new driver for LP8755")
Suggested-by: Adam Thomson <Adam.Thomson.Opensource@diasemi.com>
Signed-off-by: Steve Twiss <stwiss.opensource@diasemi.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
drivers/regulator/lp8755.c