OSDN Git Service

tls: improve lockless access safety of tls_err_abort()
authorJakub Kicinski <kuba@kernel.org>
Thu, 25 May 2023 05:17:41 +0000 (22:17 -0700)
committerDavid S. Miller <davem@davemloft.net>
Fri, 26 May 2023 09:35:58 +0000 (10:35 +0100)
commit8a0d57df8938e9fd2e99d47a85b7f37d86f91097
treef3580e647acbd306ee043c6cc59a2c1d7315a423
parentaa866ee4b15162ef92a567512f85c4357ca8e97f
tls: improve lockless access safety of tls_err_abort()

Most protos' poll() methods insert a memory barrier between
writes to sk_err and sk_error_report(). This dates back to
commit a4d258036ed9 ("tcp: Fix race in tcp_poll").

I guess we should do the same thing in TLS, tcp_poll() does
not hold the socket lock.

Fixes: 3c4d7559159b ("tls: kernel TLS support")
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Reviewed-by: Simon Horman <simon.horman@corigine.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/tls/tls_strp.c
net/tls/tls_sw.c