OSDN Git Service

drm/i915/execlist: Mark up racy read of execlists->pending[0]
authorChris Wilson <chris@chris-wilson.co.uk>
Tue, 28 Jan 2020 17:16:14 +0000 (17:16 +0000)
committerChris Wilson <chris@chris-wilson.co.uk>
Wed, 29 Jan 2020 13:13:50 +0000 (13:13 +0000)
commit8a5746982e0fdabae85990d90a9b80e107fcd450
tree47785698f67c2f75546d4f45c0b76094db6380e9
parentba12993c5228015c42dc46d634f5fa5717206c3b
drm/i915/execlist: Mark up racy read of execlists->pending[0]

We write to execlists->pending[0] in process_csb() to acknowledge the
completion of the ESLP update, outside of the main spinlock. When we
check the current status of the previous submission in
__execlists_submission_tasklet() we should therefore use READ_ONCE() to
reflect and document the unsynchronized read.

Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Reviewed-by: Mika Kuoppala <mika.kuoppala@linux.intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20200128171614.3845825-1-chris@chris-wilson.co.uk
drivers/gpu/drm/i915/gt/intel_lrc.c