OSDN Git Service

Refactoring changes: Cleanup and improvements.
authorChristian Kamm <christian.d.kamm@nokia.com>
Wed, 17 Aug 2011 09:35:57 +0000 (11:35 +0200)
committerChristian Kamm <christian.d.kamm@nokia.com>
Fri, 19 Aug 2011 09:12:09 +0000 (11:12 +0200)
commit8a6d767a8f2f98ea4e04847f92cff40d661b806f
tree586e5c539adfbb18623246d00dec5e894288c8e1
parenta07acad516b5fa1ac503493b4ec28d595f6e1ea0
Refactoring changes: Cleanup and improvements.

Previously RefactoringFiles were usually passed around by value.
However, since a RefactoringFile may sometimes own a QTextDocument
(when it was read from a file), that's not great and caused the
file to be reread after every copy.

With this change RefactoringFile becomes noncopyable and is always
owned by a shared pointer.

This change also allowed having const RefactoringFiles which is
useful because they can be safely used from other threads. See
CppRefactoringChanges::fileNoEditor.

Change-Id: I9045921d6d0f6349f9558ff2a3d8317ea172193b
Reviewed-on: http://codereview.qt.nokia.com/3084
Reviewed-by: Leandro T. C. Melo <leandro.melo@nokia.com>
30 files changed:
src/libs/cplusplus/ASTPath.cpp
src/libs/cplusplus/ASTPath.h
src/plugins/cppeditor/cppcompleteswitch.cpp
src/plugins/cppeditor/cppfunctiondecldeflink.cpp
src/plugins/cppeditor/cppfunctiondecldeflink.h
src/plugins/cppeditor/cppinsertdecldef.cpp
src/plugins/cppeditor/cppinsertqtpropertymembers.cpp
src/plugins/cppeditor/cppinsertqtpropertymembers.h
src/plugins/cppeditor/cppquickfix.cpp
src/plugins/cppeditor/cppquickfix.h
src/plugins/cppeditor/cppquickfixassistant.cpp
src/plugins/cppeditor/cppquickfixassistant.h
src/plugins/cppeditor/cppquickfixes.cpp
src/plugins/cpptools/cpprefactoringchanges.cpp
src/plugins/cpptools/cpprefactoringchanges.h
src/plugins/cpptools/insertionpointlocator.cpp
src/plugins/cpptools/insertionpointlocator.h
src/plugins/designer/qtcreatorintegration.cpp
src/plugins/qmljseditor/qmljscomponentfromobjectdef.cpp
src/plugins/qmljseditor/qmljsquickfix.cpp
src/plugins/qmljseditor/qmljsquickfix.h
src/plugins/qmljseditor/qmljsquickfixassist.cpp
src/plugins/qmljseditor/qmljsquickfixassist.h
src/plugins/qmljseditor/qmljsquickfixes.cpp
src/plugins/qmljseditor/qmloutlinemodel.cpp
src/plugins/qmljstools/qmljsrefactoringchanges.cpp
src/plugins/qmljstools/qmljsrefactoringchanges.h
src/plugins/texteditor/basetexteditor.cpp
src/plugins/texteditor/refactoringchanges.cpp
src/plugins/texteditor/refactoringchanges.h