OSDN Git Service

Enable -Wsuggest-override in the LLVM build
authorLogan Smith <logan.r.smith0@gmail.com>
Mon, 20 Jul 2020 17:06:11 +0000 (10:06 -0700)
committerLogan Smith <logan.r.smith0@gmail.com>
Mon, 20 Jul 2020 19:32:47 +0000 (12:32 -0700)
commit8b16e45f66e24e4c10e2cea1b70d2b85a7ce64d5
tree11fa9885b4e26049d3e9d0c7628645ad40219142
parent9f5d8e8a729dddbb7c2e020df1507273d1c98fcb
Enable -Wsuggest-override in the LLVM build

This patch adds Clang's new (and GCC's old) -Wsuggest-override to the warning flags for the LLVM build. The warning is a stronger form of -Winconsistent-missing-override which warns _everywhere_ that override is missing, not just in places where it's inconsistent within a class.

Some directories in the monorepo need the warning disabled for compatibility's, or sanity's, sake; in particular, libcxx/libcxxabi, and any code implementing or interoperating with googletest, googlemock, or google benchmark (which do not themselves use override). This patch adds -Wno-suggest-override to the relevant CMakeLists.txt's to accomplish this.

Differential Revision: https://reviews.llvm.org/D84126
libcxx/CMakeLists.txt
libcxxabi/CMakeLists.txt
lldb/unittests/CMakeLists.txt
llvm/cmake/modules/HandleLLVMOptions.cmake
llvm/utils/benchmark/CMakeLists.txt
llvm/utils/unittest/CMakeLists.txt