OSDN Git Service

rtlwifi: rtl8723ae: avoid accessing the data mapped to streaming DMA
authorJia-Ju Bai <baijiaju1990@gmail.com>
Thu, 19 Nov 2020 01:52:18 +0000 (09:52 +0800)
committerKalle Valo <kvalo@codeaurora.org>
Tue, 24 Nov 2020 15:06:38 +0000 (17:06 +0200)
commit8b2c13b2e5dab8f2ace44cc775096c6fae0a6f72
tree52604964538367edff27d6b4fa059e8a6e89b9cf
parentff76548338947c2c45b7aaf1d182e331398279b7
rtlwifi: rtl8723ae: avoid accessing the data mapped to streaming DMA

In rtl8723e_tx_fill_cmddesc(), skb->data is mapped to streaming DMA on
line 531:
  dma_addr_t mapping = dma_map_single(..., skb->data, ...);

On line 534, skb->data is assigned to hdr after cast:
  struct ieee80211_hdr *hdr = (struct ieee80211_hdr *)(skb->data);

Then hdr->frame_control is accessed on line 535:
  __le16 fc = hdr->frame_control;

This DMA access may cause data inconsistency between CPU and hardwre.

To fix this bug, hdr->frame_control is accessed before the DMA mapping.

Signed-off-by: Jia-Ju Bai <baijiaju1990@gmail.com>
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
Link: https://lore.kernel.org/r/20201119015218.12220-1-baijiaju1990@gmail.com
drivers/net/wireless/realtek/rtlwifi/rtl8723ae/trx.c