OSDN Git Service

regmap: verify if register is writeable before writing operations
authorHan Nandor <nandor.han@vaisala.com>
Tue, 2 Apr 2019 08:01:22 +0000 (08:01 +0000)
committerMark Brown <broonie@kernel.org>
Wed, 3 Apr 2019 04:08:11 +0000 (11:08 +0700)
commit8b9f9d4dc511309918c4f6793bae7387c0c638af
tree9f7462507251668ce2e5dabcc65d45dbcb3f7277
parentcc6a8d69ba624f0ad7a09ed095b7bd4b86476489
regmap: verify if register is writeable before writing operations

regmap provides a couple of ways to validate the register range used.
a) maxim allowed register, b) writable/readable register tables,
c) callback function that can be provided by the driver to validate
a register. regmap framework should verify if registers
are writeable before every write operation. However this doesn't
seems to happen in every situation.

The method `_regmap_raw_write_impl` is only using the `writeable_reg`
callback to verify if register is writeable, ignoring the other two.
This can lead to undefined behaviour since this allows to write to
registers that could be declared un-writeable by using any other
option.

Change `_regmap_raw_write_impl` to use the `regmap_writeable` method
to verify if registers are writable before the write operation.

Signed-off-by: Nandor Han <nandor.han@vaisala.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
drivers/base/regmap/regmap.c