OSDN Git Service

openvswitch: Change the return type for vport_ops.send function hook to int
authorNathan Huckleberry <nhuck@google.com>
Tue, 13 Sep 2022 23:07:38 +0000 (16:07 -0700)
committerJakub Kicinski <kuba@kernel.org>
Tue, 20 Sep 2022 01:28:50 +0000 (18:28 -0700)
commit8bb7c4f8c9276eb61f7f39cc107f67a0e81de610
tree98a1e3bcf5bdb316795d9335de4dae25abfbc3ff
parent73c99e26036529e633a0f2d628ad7ddff6594668
openvswitch: Change the return type for vport_ops.send function hook to int

All usages of the vport_ops struct have the .send field set to
dev_queue_xmit or internal_dev_recv.  Since most usages are set to
dev_queue_xmit, the function hook should match the signature of
dev_queue_xmit.

The only call to vport_ops->send() is in net/openvswitch/vport.c and it
throws away the return value.

This mismatched return type breaks forward edge kCFI since the underlying
function definition does not match the function hook definition.

Reported-by: Dan Carpenter <error27@gmail.com>
Link: https://github.com/ClangBuiltLinux/linux/issues/1703
Cc: llvm@lists.linux.dev
Signed-off-by: Nathan Huckleberry <nhuck@google.com>
Reviewed-by: Nathan Chancellor <nathan@kernel.org>
Acked-by: Eelco Chaudron <echaudro@redhat.com>
Link: https://lore.kernel.org/r/20220913230739.228313-1-nhuck@google.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
net/openvswitch/vport-internal_dev.c
net/openvswitch/vport.h