OSDN Git Service

scsi: esp_scsi: Eliminate ESP_FLAG_DOING_SLOWCMD
authorFinn Thain <fthain@telegraphics.com.au>
Tue, 16 Oct 2018 05:31:25 +0000 (16:31 +1100)
committerMartin K. Petersen <martin.petersen@oracle.com>
Thu, 18 Oct 2018 01:37:31 +0000 (21:37 -0400)
commit8bca2143335116af838305440d94539367382555
tree81997190f787438ac2cb91981f2888f9a1d35f0e
parent87c58ef5a57f46b1d78117317a7d8806ad16f404
scsi: esp_scsi: Eliminate ESP_FLAG_DOING_SLOWCMD

The concept of a 'slow command' as it appears in esp_scsi is confusing
because it could refer to an ESP command or a SCSI command. It turns out
that it refers to a particular ESP select command which the driver also
tracks as 'ESP_SELECT_MSGOUT'. For readability, it is better to use the
terminology from the datasheets.

The global ESP_FLAG_DOING_SLOWCMD flag is redundant anyway, as it can be
inferred from esp->select_state. Remove the ESP_FLAG_DOING_SLOWCMD cruft
and just use a boolean local variable.

Tested-by: Stan Johnson <userm57@yahoo.com>
Signed-off-by: Finn Thain <fthain@telegraphics.com.au>
Tested-by: Michael Schmitz <schmitzmic@gmail.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/scsi/esp_scsi.c
drivers/scsi/esp_scsi.h