OSDN Git Service

dt: bindings: net: use boolean dt properties for eee broken modes
authorjbrunet <jbrunet@baylibre.com>
Mon, 19 Dec 2016 15:05:38 +0000 (16:05 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 5 Jul 2017 12:40:20 +0000 (14:40 +0200)
commit8bface142a8d4bc5766bc71c94a618f234ed2bc6
tree14681403cbe90914b0efc1707fe7b1054d8d7317
parent3897ae12b706bfc47c07a1eef58fe6ce328784cf
dt: bindings: net: use boolean dt properties for eee broken modes

[ Upstream commit 308d3165d8b2b98d3dc3d97d6662062735daea67 ]

The patches regarding eee-broken-modes was merged before all people
involved could find an agreement on the best way to move forward.

While we agreed on having a DT property to mark particular modes as broken,
the value used for eee-broken-modes mapped the phy register in very direct
way. Because of this, the concern is that it could be used to implement
configuration policies instead of describing a broken HW.

In the end, having a boolean property for each mode seems to be preferred
over one bit field value mapping the register (too) directly.

Cc: Florian Fainelli <f.fainelli@gmail.com>
Signed-off-by: Jerome Brunet <jbrunet@baylibre.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Sasha Levin <alexander.levin@verizon.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Documentation/devicetree/bindings/net/phy.txt
include/dt-bindings/net/mdio.h [deleted file]