OSDN Git Service

drm/bridge: ti-sn65dsi86: Fix output polarity setting bug
authorQiqi Zhang <eddy.zhang@rock-chips.com>
Fri, 25 Nov 2022 10:45:58 +0000 (18:45 +0800)
committerDouglas Anderson <dianders@chromium.org>
Wed, 30 Nov 2022 14:40:20 +0000 (06:40 -0800)
commit8c115864501fc09932cdfec53d9ec1cde82b4a28
treee6a9002a4105794532bcac4ccfab5f0ecff42c1a
parented14d225cc7c842f6d4d5a3009f71a44f5852d09
drm/bridge: ti-sn65dsi86: Fix output polarity setting bug

According to the description in ti-sn65dsi86's datasheet:

CHA_HSYNC_POLARITY:
0 = Active High Pulse. Synchronization signal is high for the sync
pulse width. (default)
1 = Active Low Pulse. Synchronization signal is low for the sync
pulse width.

CHA_VSYNC_POLARITY:
0 = Active High Pulse. Synchronization signal is high for the sync
pulse width. (Default)
1 = Active Low Pulse. Synchronization signal is low for the sync
pulse width.

We should only set these bits when the polarity is negative.

Fixes: a095f15c00e2 ("drm/bridge: add support for sn65dsi86 bridge driver")
Signed-off-by: Qiqi Zhang <eddy.zhang@rock-chips.com>
Reviewed-by: Douglas Anderson <dianders@chromium.org>
Tested-by: Douglas Anderson <dianders@chromium.org>
Reviewed-by: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>
Signed-off-by: Douglas Anderson <dianders@chromium.org>
Link: https://patchwork.freedesktop.org/patch/msgid/20221125104558.84616-1-eddy.zhang@rock-chips.com
drivers/gpu/drm/bridge/ti-sn65dsi86.c