OSDN Git Service

drm/ssd130x: Use shadow-buffer helpers when managing plane's state
authorJavier Martinez Canillas <javierm@redhat.com>
Thu, 27 Jul 2023 14:04:19 +0000 (16:04 +0200)
committerJavier Martinez Canillas <javierm@redhat.com>
Thu, 27 Jul 2023 15:44:41 +0000 (17:44 +0200)
commit8c3926367ac9df6c25297de2d1d06be34cfd6985
tree0ae6539c94eaa35274b179ae9a3b4f64a9eaf85c
parent7c5aa9485871f61d19ad2cecbf4904ea05a39ec4
drm/ssd130x: Use shadow-buffer helpers when managing plane's state

The commit 45b58669e532 ("drm/ssd130x: Allocate buffer in the plane's
.atomic_check() callback") moved the buffers allocation to be done in
the primary plane's .atomic_check() callback.

But it missed that since the driver uses a shadow-buffered plane, the
__drm_gem_{reset,duplicate,destroy}_shadow_plane() helper functions
must be used in the struct drm_plane_funcs handlers.

This was missed because the mentioned commit did not remove the macro
DRM_GEM_SHADOW_PLANE_FUNCS, which leads to the custom plane's atomic
state management handlers to not be used.

Fixes: 45b58669e532 ("drm/ssd130x: Allocate buffer in the plane's .atomic_check() callback")
Reported-by: Arnd Bergmann <arnd@arndb.de>
Closes: https://lore.kernel.org/dri-devel/20230727122412.2464210-1-arnd@kernel.org
Suggested-by: Thomas Zimmermann <tzimmermann@suse.de>
Signed-off-by: Javier Martinez Canillas <javierm@redhat.com>
Reviewed-by: Thomas Zimmermann <tzimmermann@suse.de>
Link: https://patchwork.freedesktop.org/patch/msgid/20230727140453.577445-1-javierm@redhat.com
drivers/gpu/drm/solomon/ssd130x.c