OSDN Git Service

drm: mxsfb: Use BIT() macro to define register bitfields
authorLaurent Pinchart <laurent.pinchart@ideasonboard.com>
Mon, 27 Jul 2020 02:06:35 +0000 (05:06 +0300)
committerStefan Agner <stefan@agner.ch>
Tue, 28 Jul 2020 15:20:23 +0000 (17:20 +0200)
commit8c6619ff22113666b112cace7e4e8d872e09dff3
treece47fc50965a18c63001804fcfd20b854bf5da35
parentc42001e357f7de11e882f54461be27757a7fe51a
drm: mxsfb: Use BIT() macro to define register bitfields

Using BIT() is preferred over manual shifts as it's more readable,
handles the 1 << 31 case properly, and avoids other mistakes as shown by
the DEBUG0_HSYNC and DEBUG0_VSYNC bits (that are currently unused). Use
it.

Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Reviewed-by: Stefan Agner <stefan@agner.ch>
Reviewed-by: Emil Velikov <emil.l.velikov@gmail.com>
Signed-off-by: Stefan Agner <stefan@agner.ch>
Link: https://patchwork.freedesktop.org/patch/msgid/20200727020654.8231-4-laurent.pinchart@ideasonboard.com
drivers/gpu/drm/mxsfb/mxsfb_regs.h