OSDN Git Service

brcmfmac: fix roamoff=1 modparam
authorStijn Tintel <stijn@linux-ipv6.be>
Tue, 4 Dec 2018 18:29:05 +0000 (20:29 +0200)
committerKalle Valo <kvalo@codeaurora.org>
Thu, 20 Dec 2018 06:47:53 +0000 (08:47 +0200)
commit8c892df41500469729e0d662816300196e4f463d
tree4d69a8b37ec04c38d6b54dc5f1df46e316b43124
parentcc4dc97ffc69c253d5aa2c0068545ed6c8bc0bde
brcmfmac: fix roamoff=1 modparam

When the update_connect_param callback is set, nl80211 expects the flag
WIPHY_FLAG_SUPPORTS_FW_ROAM to be set as well. However, this flag is
only set when modparam roamoff=0, while the callback is set
unconditionally. Since commit 7f9a3e150ec7 this causes a warning in
wiphy_register, which breaks brcmfmac.

Disable the update_connect_param callback when roamoff=0 to fix this.

Fixes: 7f9a3e150ec7 ("nl80211: Update ERP info using NL80211_CMD_UPDATE_CONNECT_PARAMS")
Cc: Stable <stable@vger.kernel.org> # 4.19+
Signed-off-by: Jonas Gorski <jonas.gorski@gmail.com>
Signed-off-by: Stijn Tintel <stijn@linux-ipv6.be>
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c
drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.h
drivers/net/wireless/broadcom/brcm80211/brcmfmac/core.c