OSDN Git Service

net: qrtr: fix usage of idr in port assignment to socket
authorNecip Fazil Yildiran <necip@google.com>
Mon, 17 Aug 2020 15:54:48 +0000 (15:54 +0000)
committerDavid S. Miller <davem@davemloft.net>
Mon, 17 Aug 2020 22:00:41 +0000 (15:00 -0700)
commit8dfddfb79653df7c38a9c8c4c034f242a36acee9
tree98fd3a5d768b8aab2f3fea92995bd91f54b23e38
parentbcf7ddb0186d366f761f86196b480ea6dd2dc18c
net: qrtr: fix usage of idr in port assignment to socket

Passing large uint32 sockaddr_qrtr.port numbers for port allocation
triggers a warning within idr_alloc() since the port number is cast
to int, and thus interpreted as a negative number. This leads to
the rejection of such valid port numbers in qrtr_port_assign() as
idr_alloc() fails.

To avoid the problem, switch to idr_alloc_u32() instead.

Fixes: bdabad3e363d ("net: Add Qualcomm IPC router")
Reported-by: syzbot+f31428628ef672716ea8@syzkaller.appspotmail.com
Signed-off-by: Necip Fazil Yildiran <necip@google.com>
Reviewed-by: Dmitry Vyukov <dvyukov@google.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/qrtr/qrtr.c