OSDN Git Service

KVM: X86: correct meaningless kvm_apicv_activated() check
authorPaolo Bonzini <pbonzini@redhat.com>
Sat, 14 Mar 2020 11:29:23 +0000 (12:29 +0100)
committerPaolo Bonzini <pbonzini@redhat.com>
Mon, 16 Mar 2020 16:58:59 +0000 (17:58 +0100)
commit8e205a6b2a06764a4c2bfc9e1a6a8a8e7920faf8
treef28323015730289c4f9d57a023bd404ab016cf30
parent212617dbb6bac2a21dec6ef7d6012d96bb6dbb5d
KVM: X86: correct meaningless kvm_apicv_activated() check

After test_and_set_bit() for kvm->arch.apicv_inhibit_reasons, we will
always get false when calling kvm_apicv_activated() because it's sure
apicv_inhibit_reasons do not equal to 0.

What the code wants to do, is check whether APICv was *already* active
and if so skip the costly request; we can do this using cmpxchg.

Reported-by: Miaohe Lin <linmiaohe@huawei.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
arch/x86/kvm/x86.c