OSDN Git Service

Add CheckTableNotInUse calls in DROP TABLE and DROP INDEX.
authorTom Lane <tgl@sss.pgh.pa.us>
Tue, 15 Feb 2011 20:49:59 +0000 (15:49 -0500)
committerTom Lane <tgl@sss.pgh.pa.us>
Tue, 15 Feb 2011 20:49:59 +0000 (15:49 -0500)
commit8e4b1473126cc72fa9bcc5b079055c71bc267656
tree7c82ac5784995e5a7e747a54963ecc11a264972e
parent888fda809239f2b4c7daa992f504c495f7ec7c92
Add CheckTableNotInUse calls in DROP TABLE and DROP INDEX.

Recent releases had a check on rel->rd_refcnt in heap_drop_with_catalog,
but failed to cover the possibility of pending trigger events at DROP time.
(Before 8.4 we didn't even check the refcnt.)  When the trigger events were
eventually fired, you'd get "could not open relation with OID nnn" errors,
as in recent report from strk.  Better to throw a suitable error when the
DROP is attempted.

Also add a similar check in DROP INDEX.

Back-patch to all supported branches.
src/backend/catalog/heap.c
src/backend/catalog/index.c
src/interfaces/ecpg/test/expected/sql-fetch.stderr