OSDN Git Service

net: dsa: mt7530: Add of_node_put() before break and return statements
authorSumera Priyadarsini <sylphrenadin@gmail.com>
Mon, 24 Aug 2020 20:03:11 +0000 (01:33 +0530)
committerDavid S. Miller <davem@davemloft.net>
Tue, 25 Aug 2020 14:44:41 +0000 (07:44 -0700)
commit8e4efd4706f77d76c99f78f8859e1d61fae5142a
tree2fb1e0cf3eb4d4bb6bbc26fa22edbb314b57d740
parentb274e47d9e3f4dcd4ad4028a316ec22dc4533ac7
net: dsa: mt7530: Add of_node_put() before break and return statements

Every iteration of for_each_child_of_node() decrements
the reference count of the previous node, however when control
is transferred from the middle of the loop, as in the case of
a return or break or goto, there is no decrement thus ultimately
resulting in a memory leak.

Fix a potential memory leak in mt7530.c by inserting of_node_put()
before the break and return statements.

Issue found with Coccinelle.

Signed-off-by: Sumera Priyadarsini <sylphrenadin@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/dsa/mt7530.c