OSDN Git Service

drm/mxsfb: Use drm_fbdev_generic_setup()
authorNoralf Trønnes <noralf@tronnes.org>
Wed, 28 Nov 2018 21:27:10 +0000 (22:27 +0100)
committerNoralf Trønnes <noralf@tronnes.org>
Mon, 14 Jan 2019 11:35:05 +0000 (12:35 +0100)
commit8e93f1028d7434af58097eadf1f34ddfa7fe2b7e
tree26685db3ea61b6776820f592b2896530a67609ef
parent331bd404a1b5394dd92573e95dd942d88675da51
drm/mxsfb: Use drm_fbdev_generic_setup()

The CMA helper is already using the drm_fb_helper_generic_probe part of
the generic fbdev emulation. This patch makes full use of the generic
fbdev emulation by using its drm_client callbacks. This means that
drm_mode_config_funcs->output_poll_changed and drm_driver->lastclose are
now handled by the emulation code. Additionally fbdev unregister happens
automatically on drm_dev_unregister().

The drm_fbdev_generic_setup() call is put after drm_dev_register() in the
driver. This is done to highlight the fact that fbdev emulation is an
internal client that makes use of the driver, it is not part of the
driver as such. If fbdev setup fails, an error is printed, but the driver
succeeds probing.

Cc: Marek Vasut <marex@denx.de>
Signed-off-by: Noralf Trønnes <noralf@tronnes.org>
Acked-by: Sam Ravnborg <sam@ravnborg.org>
Link: https://patchwork.freedesktop.org/patch/msgid/20181128212713.43500-3-noralf@tronnes.org
drivers/gpu/drm/mxsfb/mxsfb_drv.c
drivers/gpu/drm/mxsfb/mxsfb_drv.h