OSDN Git Service

epic100: fix use after free on rmmod
authorTong Zhang <ztong0001@gmail.com>
Mon, 27 Jun 2022 04:33:48 +0000 (21:33 -0700)
committerJakub Kicinski <kuba@kernel.org>
Tue, 28 Jun 2022 04:48:51 +0000 (21:48 -0700)
commit8ee9d82cd0a45e7d050ade598c9f33032a0f2891
treed2896ac471cd98f1f94936393ae659a0364b7f75
parenta8fc8cb5692aebb9c6f7afd4265366d25dcd1d01
epic100: fix use after free on rmmod

epic_close() calls epic_rx() and uses dma buffer, but in epic_remove_one()
we already freed the dma buffer. To fix this issue, reorder function calls
like in the .probe function.

BUG: KASAN: use-after-free in epic_rx+0xa6/0x7e0 [epic100]
Call Trace:
 epic_rx+0xa6/0x7e0 [epic100]
 epic_close+0xec/0x2f0 [epic100]
 unregister_netdev+0x18/0x20
 epic_remove_one+0xaa/0xf0 [epic100]

Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")
Reported-by: Yilun Wu <yiluwu@cs.stonybrook.edu>
Signed-off-by: Tong Zhang <ztong0001@gmail.com>
Reviewed-by: Francois Romieu <romieu@fr.zoreil.com>
Link: https://lore.kernel.org/r/20220627043351.25615-1-ztong0001@gmail.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/ethernet/smsc/epic100.c