OSDN Git Service

IPv6: Set SIT tunnel hard_header_len to zero
authorOliver Herms <oliver.peter.herms@gmail.com>
Tue, 3 Nov 2020 10:41:33 +0000 (11:41 +0100)
committerJakub Kicinski <kuba@kernel.org>
Mon, 9 Nov 2020 23:07:40 +0000 (15:07 -0800)
commit8ef9ba4d666614497a057d09b0a6eafc1e34eadf
treebf36b5fe991724c4d7fa37cb7a146580637fd98a
parent4e0396c59559264442963b349ab71f66e471f84d
IPv6: Set SIT tunnel hard_header_len to zero

Due to the legacy usage of hard_header_len for SIT tunnels while
already using infrastructure from net/ipv4/ip_tunnel.c the
calculation of the path MTU in tnl_update_pmtu is incorrect.
This leads to unnecessary creation of MTU exceptions for any
flow going over a SIT tunnel.

As SIT tunnels do not have a header themsevles other than their
transport (L3, L2) headers we're leaving hard_header_len set to zero
as tnl_update_pmtu is already taking care of the transport headers
sizes.

This will also help avoiding unnecessary IPv6 GC runs and spinlock
contention seen when using SIT tunnels and for more than
net.ipv6.route.gc_thresh flows.

Fixes: c54419321455 ("GRE: Refactor GRE tunneling code.")
Signed-off-by: Oliver Herms <oliver.peter.herms@gmail.com>
Acked-by: Willem de Bruijn <willemb@google.com>
Link: https://lore.kernel.org/r/20201103104133.GA1573211@tws
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
net/ipv6/sit.c