OSDN Git Service

drm/virtio: fix potential integer overflow on shift of a int
authorColin Ian King <colin.king@canonical.com>
Thu, 30 Sep 2021 10:19:41 +0000 (11:19 +0100)
committerGerd Hoffmann <kraxel@redhat.com>
Fri, 29 Oct 2021 06:26:23 +0000 (08:26 +0200)
commit8f4502fa284478a5264afa8a5a95511276fa9b80
treedafb4a4369893aa19bcfe927529111cc8736fb57
parent7cf09865885793f57003492f1cd3b76cf4cf0eb1
drm/virtio: fix potential integer overflow on shift of a int

The left shift of unsigned int 32 bit integer constant 1 is evaluated
using 32 bit arithmetic and then assigned to a signed 64 bit integer.
In the case where i is 32 or more this can lead to an overflow. Fix
this by shifting the value 1ULL instead.

Addresses-Coverity: ("Uninitentional integer overflow")
Fixes: 8d6b006e1f51 ("drm/virtio: implement context init: handle VIRTGPU_CONTEXT_PARAM_POLL_RINGS_MASK")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Link: http://patchwork.freedesktop.org/patch/msgid/20210930101941.16546-1-colin.king@canonical.com
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
drivers/gpu/drm/virtio/virtgpu_ioctl.c