OSDN Git Service

qed: Avoid implicit enum conversion in qed_ooo_submit_tx_buffers
authorNathan Chancellor <natechancellor@gmail.com>
Thu, 4 Oct 2018 16:39:20 +0000 (09:39 -0700)
committerDavid S. Miller <davem@davemloft.net>
Thu, 4 Oct 2018 16:57:26 +0000 (09:57 -0700)
commit8fa74e3c49204bdf788d99ef71840490cccc210d
treeb0d761ab2ff2a7869c7d499de7f4e857525eca06
parent9e50727f0e710e25e9fd740c9f43f51b37757773
qed: Avoid implicit enum conversion in qed_ooo_submit_tx_buffers

Clang warns when one enumerated type is implicitly converted to another.

drivers/net/ethernet/qlogic/qed/qed_ll2.c:799:32: warning: implicit
conversion from enumeration type 'enum core_tx_dest' to different
enumeration type 'enum qed_ll2_tx_dest' [-Wenum-conversion]
                tx_pkt.tx_dest = p_ll2_conn->tx_dest;
                               ~ ~~~~~~~~~~~~^~~~~~~
1 warning generated.

Fix this by using a switch statement to convert between the enumerated
values since they are not 1 to 1, which matches how the rest of the
driver handles this conversion.

Link: https://github.com/ClangBuiltLinux/linux/issues/125
Suggested-by: Tomer Tayar <Tomer.Tayar@cavium.com>
Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
Acked-by: Tomer Tayar <Tomer.Tayar@cavium.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/qlogic/qed/qed_ll2.c