OSDN Git Service

md: fix another deadlock with removing sysfs attributes.
authorNeilBrown <neilb@suse.de>
Sun, 8 Aug 2010 11:18:03 +0000 (21:18 +1000)
committerGreg Kroah-Hartman <gregkh@suse.de>
Fri, 13 Aug 2010 20:30:48 +0000 (13:30 -0700)
commit8fa8b10c9dc5729d3af41babae879b48ab4ee095
tree7fc01a31d19895623403a0b7f7d604d664f1e6a9
parent3b9f17f709e0b691940bfd9eda45b716932696f6
md: fix another deadlock with removing sysfs attributes.

commit bb4f1e9d0e2ef93de8e36ca0f5f26625fcd70b7d upstream.

Move the deletion of sysfs attributes from reconfig_mutex to
open_mutex didn't really help as a process can try to take
open_mutex while holding reconfig_mutex, so the same deadlock can
happen, just requiring one more process to be involved in the chain.

I looks like I cannot easily use locking to wait for the sysfs
deletion to complete, so don't.

The only things that we cannot do while the deletions are still
pending is other things which can change the sysfs namespace: run,
takeover, stop.  Each of these can fail with -EBUSY.
So set a flag while doing a sysfs deletion, and fail run, takeover,
stop if that flag is set.

This is suitable for 2.6.35.x

Signed-off-by: NeilBrown <neilb@suse.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
drivers/md/md.c
drivers/md/md.h