OSDN Git Service

scsi: target: Remove XDWRITEREAD emulated support
authorMike Christie <michael.christie@oracle.com>
Tue, 26 Jul 2022 23:53:39 +0000 (18:53 -0500)
committerMartin K. Petersen <martin.petersen@oracle.com>
Wed, 27 Jul 2022 02:40:31 +0000 (22:40 -0400)
commit8fcdc238ce1b492e1f57a73a2ce4131d63f45397
tree11868566bfc8b58104caa09847cac87c10eb1809
parent68126eeb6df6cb53aae4dc450ec20792e1819861
scsi: target: Remove XDWRITEREAD emulated support

This patch removes XDWRITEREAD support because it never fully worked when
it was added in the initial LIO merge and it's been fully broken since 2013
from commit a2890087499a ("target: Add compare_and_write_post() completion
callback fall through").

The two issues above are:

1. XDWRITEREAD support was just never completed when LIO was merged. We
never did the DISABLE WRITE check and so we never write data out.

2. Since the commit above, we never complete the command. After we do the
XOR, we return from xdreadwrite_callback and that's it. We never send a
response for the command, so the command will always time out and fail.

Since this has been fully broken for almost nine years this patch just
removes emulated support.

Link: https://lore.kernel.org/r/20220726235339.14551-1-michael.christie@oracle.com
Signed-off-by: Mike Christie <michael.christie@oracle.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/target/target_core_sbc.c