OSDN Git Service

Fix a long-standing miscompile in the load analysis that was uncovered
authorChandler Carruth <chandlerc@gmail.com>
Sun, 19 Oct 2014 08:17:50 +0000 (08:17 +0000)
committerChandler Carruth <chandlerc@gmail.com>
Sun, 19 Oct 2014 08:17:50 +0000 (08:17 +0000)
commit908d4514f689035f1d36e03110e2cbc375360421
treea1c365dac89055e1671aeacdd78d8475e9aea88a
parentf84407be32116bd50b9074b51ea3e37ec68515f8
Fix a long-standing miscompile in the load analysis that was uncovered
by my refactoring of this code.

The method isSafeToLoadUnconditionally assumes that the load will
proceed with the preferred type alignment. Given that, it has to ensure
that the alloca or global is at least that aligned. It has always done
this historically when a datalayout is present, but has never checked it
when the datalayout is absent. When I refactored the code in r220156,
I exposed this path when datalayout was present and that turned the
latent bug into a patent bug.

This fixes the issue by just removing the special case which allows
folding things without datalayout. This isn't worth the complexity of
trying to tease apart when it is or isn't safe without actually knowing
the preferred alignment.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@220161 91177308-0d34-0410-b5e6-96231b3b80d8
lib/Analysis/Loads.cpp
lib/Transforms/Scalar/TailRecursionElimination.cpp
test/Transforms/InstCombine/load.ll
test/Transforms/InstCombine/select.ll
test/Transforms/TailCallElim/reorder_load.ll