OSDN Git Service

hw/net/vmxnet3: Fix guest-triggerable assert()
authorThomas Huth <thuth@redhat.com>
Thu, 17 Aug 2023 12:56:00 +0000 (14:56 +0200)
committerMichael Tokarev <mjt@tls.msk.ru>
Fri, 8 Sep 2023 10:08:52 +0000 (13:08 +0300)
commit90a0778421acdf4ca903be64c8ed19378183c944
tree7da6cdd63d5c962145d73df2869a714eedbd3411
parent0084f6834a13aedaf4375fa34161c2f6ff0aeaa8
hw/net/vmxnet3: Fix guest-triggerable assert()

The assert() that checks for valid MTU sizes can be triggered by
the guest (e.g. with the reproducer code from the bug ticket
https://gitlab.com/qemu-project/qemu/-/issues/517 ). Let's avoid
this problem by simply logging the error and refusing to activate
the device instead.

Fixes: d05dcd94ae ("net: vmxnet3: validate configuration values during activate")
Signed-off-by: Thomas Huth <thuth@redhat.com>
Cc: qemu-stable@nongnu.org
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
[Mjt: change format specifier from %d to %u for uint32_t argument]
hw/net/vmxnet3.c