OSDN Git Service

ravb: Use GFP_KERNEL instead of GFP_ATOMIC when possible
authorChristophe JAILLET <christophe.jaillet@wanadoo.fr>
Sun, 20 Feb 2022 07:27:15 +0000 (08:27 +0100)
committerDavid S. Miller <davem@davemloft.net>
Mon, 21 Feb 2022 12:00:46 +0000 (12:00 +0000)
commit91398a960edf50d27206d808182e3357f9f5c668
tree3a1d3108077046f007f7a8ffa78d06912c5391a2
parent354ad9a89399d845210d0cf18d46c6e22aac1029
ravb: Use GFP_KERNEL instead of GFP_ATOMIC when possible

'max_rx_len' can be up to GBETH_RX_BUFF_MAX (i.e. 8192) (see
'gbeth_hw_info').
The default value of 'num_rx_ring' can be BE_RX_RING_SIZE (i.e. 1024).

So this loop can allocate 8 Mo of memory.

Previous memory allocations in this function already use GFP_KERNEL, so
use __netdev_alloc_skb() and an explicit GFP_KERNEL instead of a
implicit GFP_ATOMIC.

This gives more opportunities of successful allocation.

Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Reviewed-by: Sergey Shtylyov <s.shtylyov@omp.ru>
Reviewed-by: Biju Das <biju.das.jz@bp.renesas.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/renesas/ravb_main.c