OSDN Git Service

iwlwifi: eeprom-parse: use struct_size() in kzalloc()
authorGustavo A. R. Silva <gustavo@embeddedor.com>
Tue, 8 Jan 2019 17:17:38 +0000 (11:17 -0600)
committerLuca Coelho <luciano.coelho@intel.com>
Wed, 20 Feb 2019 18:47:54 +0000 (20:47 +0200)
commit9178aa7c465440bae84a0de002d919ad7034a08a
tree2f73f8740b8eeef21033d109c82004c3a71ecda1
parente8698301f2c13ea4b0e78f2ed8a15b244ee3649b
iwlwifi: eeprom-parse: use struct_size() in kzalloc()

One of the more common cases of allocation size calculations is finding the
size of a structure that has a zero-sized array at the end, along with memory
for some number of elements for that array. For example:

struct foo {
    int stuff;
    void *entry[];
};

instance = kzalloc(sizeof(struct foo) + sizeof(void *) * count, GFP_KERNEL);

Instead of leaving these open-coded and prone to type mistakes, we can now
use the new struct_size() helper:

instance = kzalloc(struct_size(instance, entry, count), GFP_KERNEL);

This code was detected with the help of Coccinelle.

Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Signed-off-by: Luca Coelho <luciano.coelho@intel.com>
drivers/net/wireless/intel/iwlwifi/iwl-eeprom-parse.c