OSDN Git Service

spapr_drc.c: do not error_report() when drc->dev->id == NULL
authorDaniel Henrique Barboza <danielhb413@gmail.com>
Tue, 7 Sep 2021 00:47:51 +0000 (21:47 -0300)
committerDavid Gibson <david@gibson.dropbear.id.au>
Wed, 29 Sep 2021 09:37:39 +0000 (19:37 +1000)
commit91bd95ce162cd34ba29e9f6470ecdcaaaf1d768d
tree6bb117d6f34aafe5fecd92cd83f6873daee5f2c0
parent44d886abab268043157b08b77147cc29bff22090
spapr_drc.c: do not error_report() when drc->dev->id == NULL

The error_report() call in drc_unisolate_logical() is not considering
that drc->dev->id can be NULL, and the underlying functions error_report()
calls to do its job (vprintf(), g_strdup_printf() ...) has undefined
behavior when trying to handle "%s" with NULL arguments.

Besides, there is no utility into reporting that an unknown device was
rejected by the guest.

Acked-by: David Gibson <david@gibson.dropbear.id.au>
Reviewed-by: Greg Kurz <groug@kaod.org>
Reviewed-by: Markus Armbruster <armbru@redhat.com>
Signed-off-by: Daniel Henrique Barboza <danielhb413@gmail.com>
Message-Id: <20210907004755.424931-4-danielhb413@gmail.com>
Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
hw/ppc/spapr_drc.c