OSDN Git Service

i2c: nomadik: Fixup system suspend
authorUlf Hansson <ulf.hansson@linaro.org>
Thu, 10 Apr 2014 13:59:36 +0000 (15:59 +0200)
committerWolfram Sang <wsa@the-dreams.de>
Thu, 22 May 2014 08:09:21 +0000 (10:09 +0200)
commit9219982bc64a41ec7745668b06f86e97b498e10a
tree56771aae3c16fd5379b2bdb5989a47b295c6535d
parent8e8782c71595a5ad29e234ce6b3d2fce787fb07a
i2c: nomadik: Fixup system suspend

For !CONFIG_PM_RUNTIME, the device were never put back into active
state while resuming.

For CONFIG_PM_RUNTIME, we blindly trusted the device to be inactive
while we were about to handle it at suspend late, which is just too
optimistic.

Even if the driver uses pm_runtime_put_sync() after each tranfer to
return it's runtime PM resources, there are no guarantees this will
actually mean the device will inactivated. The reason is that the PM
core will prevent runtime suspend during system suspend, and thus when
a transfer occurs during the early phases of system suspend the device
will be kept active after the transfer.

To handle both issues above, use pm_runtime_force_suspend|resume() from
the system suspend|resume callbacks.

Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
Acked-by: Linus Walleij <linus.walleij@linaro.org>
Signed-off-by: Wolfram Sang <wsa@the-dreams.de>
drivers/i2c/busses/i2c-nomadik.c