OSDN Git Service

QIOChannelSocket: Fix zero-copy flush returning code 1 when nothing sent
authorLeonardo Bras <leobras@redhat.com>
Mon, 11 Jul 2022 21:11:11 +0000 (18:11 -0300)
committerDr. David Alan Gilbert <dgilbert@redhat.com>
Wed, 20 Jul 2022 11:15:09 +0000 (12:15 +0100)
commit927f93e099c4f9184e60a1bc61624ac2d04d0223
treefdc23458934876fe4fe162689be5004f2ee75981
parent5f87072e9532a92e6270577665aa2fa659ec0b3f
QIOChannelSocket: Fix zero-copy flush returning code 1 when nothing sent

If flush is called when no buffer was sent with MSG_ZEROCOPY, it currently
returns 1. This return code should be used only when Linux fails to use
MSG_ZEROCOPY on a lot of sendmsg().

Fix this by returning early from flush if no sendmsg(...,MSG_ZEROCOPY)
was attempted.

Fixes: 2bc58ffc2926 ("QIOChannelSocket: Implement io_writev zero copy flag & io_flush for CONFIG_LINUX")
Signed-off-by: Leonardo Bras <leobras@redhat.com>
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Acked-by: Daniel P. Berrangé <berrange@redhat.com>
Reviewed-by: Juan Quintela <quintela@redhat.com>
Reviewed-by: Peter Xu <peterx@redhat.com>
Message-Id: <20220711211112.18951-2-leobras@redhat.com>
Signed-off-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
io/channel-socket.c