OSDN Git Service

kcsan: Improve IRQ state trace reporting
authorMarco Elver <elver@google.com>
Wed, 29 Jul 2020 11:09:16 +0000 (13:09 +0200)
committerIngo Molnar <mingo@kernel.org>
Fri, 31 Jul 2020 10:12:03 +0000 (12:12 +0200)
commit92c209ac6d3d35783c16c8a717547183e6e11162
treebf34202bebc219dac144f09230b4ba6ce7d7327b
parent0584df9c12f449124d0bfef9899e5365604ee7a9
kcsan: Improve IRQ state trace reporting

To improve the general usefulness of the IRQ state trace events with
KCSAN enabled, save and restore the trace information when entering and
exiting the KCSAN runtime as well as when generating a KCSAN report.

Without this, reporting the IRQ trace events (whether via a KCSAN report
or outside of KCSAN via a lockdep report) is rather useless due to
continuously being touched by KCSAN. This is because if KCSAN is
enabled, every instrumented memory access causes changes to IRQ trace
events (either by KCSAN disabling/enabling interrupts or taking
report_lock when generating a report).

Before "lockdep: Prepare for NMI IRQ state tracking", KCSAN avoided
touching the IRQ trace events via raw_local_irq_save/restore() and
lockdep_off/on().

Fixes: 248591f5d257 ("kcsan: Make KCSAN compatible with new IRQ state tracking")
Signed-off-by: Marco Elver <elver@google.com>
Signed-off-by: Ingo Molnar <mingo@kernel.org>
Link: https://lore.kernel.org/r/20200729110916.3920464-2-elver@google.com
Signed-off-by: Ingo Molnar <mingo@kernel.org>
include/linux/sched.h
kernel/kcsan/core.c
kernel/kcsan/kcsan.h
kernel/kcsan/report.c