OSDN Git Service

drm/amdgpu_gem: fix error handling path in amdgpu_gem_va_update_vm
authorGustavo A. R. Silva <gustavo@embeddedor.com>
Thu, 15 Feb 2018 05:20:00 +0000 (23:20 -0600)
committerAlex Deucher <alexander.deucher@amd.com>
Mon, 19 Feb 2018 19:20:19 +0000 (14:20 -0500)
commit93bab704c1513f824d0e19fd02f8b57b107feceb
treebc64dfff3d0c51fbdf0319d17e4d56d9a60ada36
parentb3cd285fa68d162a53c2eb4e23bc4fc1ab7d97f6
drm/amdgpu_gem: fix error handling path in amdgpu_gem_va_update_vm

Currently, if amdgpu_vm_bo_update() fails, the returned error
is being ignored.

Fix this by properly checking _r_ after calling amdgpu_vm_bo_update.
Also, remove redundant code just before label _error_.

Addresses-Coverity-ID: 1464280 ("Unused value")
Fixes: 0abc6878fc2d ("drm/amdgpu: update VM PDs after the PTs")
Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Reviewed-by: Christian König <christian.koenig@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
drivers/gpu/drm/amd/amdgpu/amdgpu_gem.c