OSDN Git Service

ASoC: 88pm860x: Don't change pm860x->dir setting if pm860x_set_dai_sysclk fails
authorAxel Lin <axel.lin@ingics.com>
Mon, 29 Jun 2015 03:15:23 +0000 (11:15 +0800)
committerMark Brown <broonie@kernel.org>
Tue, 7 Jul 2015 12:48:59 +0000 (13:48 +0100)
commit93ec3a1ad5b86aef8ca90d2b149ded0f6bb689f5
tree7403030f98a0f435a7662aa5b5adb00bada97d1f
parentd770e558e21961ad6cfdf0ff7df0eb5d7d4f0754
ASoC: 88pm860x: Don't change pm860x->dir setting if pm860x_set_dai_sysclk fails

88pm860x does not support slave mode, so it returns -EINVAL for
PM860X_CLK_DIR_IN. Current code changes pm860x->dir setting before
return error, so it has impact on the logic of pm860x_pcm_set_dai_fmt.

This patch adds comment for the reason to return -EINVAL for
PM860X_CLK_DIR_IN, and avoid changing pm860x->dir setting if
pm860x_set_dai_sysclk fails.

Signed-off-by: Axel Lin <axel.lin@ingics.com>
Acked-by: Haojian Zhuang <haojian.zhuang@linaro.org>
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/codecs/88pm860x-codec.c