OSDN Git Service

mm/khugepaged: alloc_charge_hpage() take care of mem charge errors
authorPeter Xu <peterx@redhat.com>
Wed, 22 Feb 2023 19:52:47 +0000 (14:52 -0500)
committerAndrew Morton <akpm@linux-foundation.org>
Tue, 28 Mar 2023 23:20:06 +0000 (16:20 -0700)
commit94c02ad7ff12b988bd7ccf522f23e0b1f68659e0
treeb4100bc238e48904e2da7fd4cc2dabcd8724d69b
parent12318566c5507a5ff4507d5bc5fe45895ffb0e05
mm/khugepaged: alloc_charge_hpage() take care of mem charge errors

If memory charge failed, instead of returning the hpage but with an error,
allow the function to cleanup the folio properly, which is normally what a
function should do in this case - either return successfully, or return
with no side effect of partial runs with an indicated error.

This will also avoid the caller calling mem_cgroup_uncharge()
unnecessarily with either anon or shmem path (even if it's safe to do so).

Link: https://lkml.kernel.org/r/20230222195247.791227-1-peterx@redhat.com
Signed-off-by: Peter Xu <peterx@redhat.com>
Reviewed-by: David Stevens <stevensd@chromium.org>
Acked-by: Johannes Weiner <hannes@cmpxchg.org>
Reviewed-by: Yang Shi <shy828301@gmail.com>
Reviewed-by: Zach O'Keefe <zokeefe@google.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
mm/khugepaged.c