OSDN Git Service

gpio: pxa: Fix potential NULL dereference
authorWei Yongjun <weiyongjun1@huawei.com>
Wed, 11 Jul 2018 13:19:38 +0000 (13:19 +0000)
committerLinus Walleij <linus.walleij@linaro.org>
Fri, 13 Jul 2018 08:03:37 +0000 (10:03 +0200)
commit9506755633d0b32ef76f67c345000178e9b0dfc4
tree21b2c66ed10e22d83729264923a92352a189ab73
parent7a9a5df0a54e4b2a36a7984800d0a064b39fb3f8
gpio: pxa: Fix potential NULL dereference

platform_get_resource() may fail and return NULL, so we should
better check it's return value to avoid a NULL pointer dereference
a bit later in the code.

This is detected by Coccinelle semantic patch.

@@
expression pdev, res, n, t, e, e1, e2;
@@

res = platform_get_resource(pdev, t, n);
+ if (!res)
+   return -EINVAL;
... when != res == NULL
e = devm_ioremap(e1, res->start, e2);

Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Acked-by: Robert Jarzmik <robert.jarzmik@free.fr>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
drivers/gpio/gpio-pxa.c