OSDN Git Service

drm/amd/pm: Replace one-element array with flexible-array in struct phm_phase_sheddin...
authorGustavo A. R. Silva <gustavoars@kernel.org>
Wed, 7 Oct 2020 16:06:14 +0000 (11:06 -0500)
committerAlex Deucher <alexander.deucher@amd.com>
Fri, 9 Oct 2020 18:43:29 +0000 (14:43 -0400)
commit9526e431c5260eeebfa575ff38f2d5cd6077f8f9
tree6c58446d972289f78271e62bfc9e4d22a70bd25a
parent0e319cfeb3c3e13088e78bfc379df15358f59fb0
drm/amd/pm: Replace one-element array with flexible-array in struct phm_phase_shedding_limits_table

There is a regular need in the kernel to provide a way to declare having
a dynamically sized set of trailing elements in a structure. Kernel code
should always use “flexible array members”[1] for these cases. The older
style of one-element or zero-length arrays should no longer be used[2].

Refactor the code according to the use of a flexible-array member in
struct phm_phase_shedding_limits_table, instead of a one-element array,
and use the struct_size() helper to calculate the size for the allocation.

Also, save some heap space as the original code is multiplying
ptable->ucNumEntries by sizeof(struct phm_phase_shedding_limits_table)
when it should have multiplied it by sizeof(struct phm_phase_shedding_limits_record)
instead.

[1] https://en.wikipedia.org/wiki/Flexible_array_member
[2] https://www.kernel.org/doc/html/v5.9-rc1/process/deprecated.html#zero-length-and-one-element-arrays

Build-tested-by: kernel test robot <lkp@intel.com>
Link: https://lore.kernel.org/lkml/5f7c5d36.6PStUZp2HRxAz7IM%25lkp@intel.com/
Acked-by: Christian König <christian.koenig@amd.com>
Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
drivers/gpu/drm/amd/pm/inc/hwmgr.h
drivers/gpu/drm/amd/pm/powerplay/hwmgr/processpptables.c