OSDN Git Service

Revert "crypto: talitos - convert to use be16_add_cpu()"
authorHoria Geant? <horia.geanta@freescale.com>
Mon, 11 May 2015 17:04:49 +0000 (20:04 +0300)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 10 Jul 2015 16:45:39 +0000 (09:45 -0700)
commit956cf7f4de7930d8a39b71e507ce826752c02173
tree19473f6d401dfd7e7c93e7e03491fb782937dd90
parentc316a7bc2eb2374a332564ffe9ccdca202f64714
Revert "crypto: talitos - convert to use be16_add_cpu()"

commit 69d9cd8c592f1abce820dbce7181bbbf6812cfbd upstream.

This reverts commit 7291a932c6e27d9768e374e9d648086636daf61c.

The conversion to be16_add_cpu() is incorrect in case cryptlen is
negative due to premature (i.e. before addition / subtraction)
implicit conversion of cryptlen (int -> u16) leading to sign loss.

Cc: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
Signed-off-by: Horia Geanta <horia.geanta@freescale.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/crypto/talitos.c