OSDN Git Service

dt-bindings: phy-qcom-qmp: Add UFS PHY reset
authorEvan Green <evgreen@chromium.org>
Thu, 21 Mar 2019 17:17:54 +0000 (10:17 -0700)
committerKishon Vijay Abraham I <kishon@ti.com>
Wed, 17 Apr 2019 08:42:53 +0000 (14:12 +0530)
commit95cee0b4e30a09a411a17e9a3bc6b72ed92063da
tree81024ef1bbd219b16f5f7aaff211b16c4b1d7cb8
parent8de4acd397ab96bf3487c6a765fd2b76e2863909
dt-bindings: phy-qcom-qmp: Add UFS PHY reset

Add a required reset to the SDM845 UFS phy to express the PHY reset
bit inside the UFS controller register space. Before this change, this
reset was not expressed in the DT, and the driver utilized two different
callbacks (phy_init and phy_poweron) to implement a two-phase
initialization procedure that involved deasserting this reset between
init and poweron. This abused the two callbacks and diluted their
purpose.

That scheme does not work as regulators cannot be turned off in
phy_poweroff because they were turned on in init, rather than poweron.
The net result is that regulators are left on in suspend that shouldn't
be.

This new scheme gives the UFS reset to the PHY, so that it can fully
initialize itself in a single callback. We can then turn regulators on
during poweron and off during poweroff.

Signed-off-by: Evan Green <evgreen@chromium.org>
Reviewed-by: Rob Herring <robh@kernel.org>
Reviewed-by: Stephen Boyd <swboyd@chromium.org>
Signed-off-by: Kishon Vijay Abraham I <kishon@ti.com>
Documentation/devicetree/bindings/phy/qcom-qmp-phy.txt