OSDN Git Service

ARM: dts: qcom: ipq4019: Fix MSI IRQ type
authorNiklas Cassel <niklas.cassel@linaro.org>
Thu, 24 Jan 2019 13:00:47 +0000 (14:00 +0100)
committerAndy Gross <andy.gross@linaro.org>
Wed, 6 Feb 2019 21:53:17 +0000 (15:53 -0600)
commit97131f85c08e024df49480ed499aae8fb754067f
tree47c89a7707c56c679185061b03396bc942f2291f
parent40122db87778970c96062c9f49b42cdf6809bf94
ARM: dts: qcom: ipq4019: Fix MSI IRQ type

The databook clearly states that the MSI IRQ (msi_ctrl_int) is a level
triggered interrupt.

The msi_ctrl_int will be high for as long as any MSI status bit is set,
thus the IRQ type should be set to IRQ_TYPE_LEVEL_HIGH, causing the
IRQ handler to keep getting called, as long as any MSI status bit is set.

A git grep shows that ipq4019 is the only SoC using snps,dw-pcie that has
configured this IRQ incorrectly.

Not having the correct IRQ type defined will cause us to lose interrupts,
which in turn causes timeouts in the PCIe endpoint drivers.

Signed-off-by: Niklas Cassel <niklas.cassel@linaro.org>
Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>
Signed-off-by: Andy Gross <andy.gross@linaro.org>
arch/arm/boot/dts/qcom-ipq4019.dtsi