OSDN Git Service

block: Raise an error when backing file parameter is an empty string
authorConnor Kuehl <ckuehl@redhat.com>
Thu, 13 Aug 2020 13:47:22 +0000 (08:47 -0500)
committerKevin Wolf <kwolf@redhat.com>
Mon, 7 Sep 2020 10:23:55 +0000 (12:23 +0200)
commit975a7bd2280db5a8db96a92ff0811e08431a64c7
treed41b729e13f7b15a2733b10ea22d62fef7106644
parent7c37270b3fbe3d034ba80e488761461676e21eb4
block: Raise an error when backing file parameter is an empty string

Providing an empty string for the backing file parameter like so:

qemu-img create -f qcow2 -b '' /tmp/foo

allows the flow of control to reach and subsequently fail an assert
statement because passing an empty string to

bdrv_get_full_backing_filename_from_filename()

simply results in NULL being returned without an error being raised.

To fix this, let's check for an empty string when getting the value from
the opts list.

Reported-by: Attila Fazekas <afazekas@redhat.com>
Fixes: https://bugzilla.redhat.com/1809553
Signed-off-by: Connor Kuehl <ckuehl@redhat.com>
Message-Id: <20200813134722.802180-1-ckuehl@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
block.c
tests/qemu-iotests/049
tests/qemu-iotests/049.out