OSDN Git Service

bpf: don't enable preemption twice in smap_do_verdict
authorDaniel Borkmann <daniel@iogearbox.net>
Thu, 17 Aug 2017 15:22:36 +0000 (17:22 +0200)
committerDavid S. Miller <davem@davemloft.net>
Thu, 17 Aug 2017 17:25:18 +0000 (10:25 -0700)
commit976d28bfd1f62a3f8e5370c5e7127ff5b3499359
tree772b86c56604fa18395437281ce0861522369daf
parent8c37bc677af3458dd5598d22467fb913f31c5bb2
bpf: don't enable preemption twice in smap_do_verdict

In smap_do_verdict(), the fall-through branch leads to call
preempt_enable() twice for the SK_REDIRECT, which creates an
imbalance. Only enable it for all remaining cases again.

Fixes: 174a79ff9515 ("bpf: sockmap with sk redirect support")
Reported-by: Alexei Starovoitov <ast@kernel.org>
Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>
Acked-by: John Fastabend <john.fastabend@gmail.com>
Acked-by: Alexei Starovoitov <ast@kernel.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
kernel/bpf/sockmap.c