OSDN Git Service

ath10k: avoid possible memory access violation
authorK.T.VIJAYAKUMAAR <vijay.bvb@samsung.com>
Mon, 3 Sep 2018 17:07:44 +0000 (20:07 +0300)
committerKalle Valo <kvalo@codeaurora.org>
Thu, 6 Sep 2018 16:04:10 +0000 (19:04 +0300)
commit97c69a70dc2cecb2c3b96a66529e0082dabc2d2c
tree7aa59dbc00b5e5c88447653683a8a63613d55365
parent85dd28eb9917fb22095aab0cf22eaa351bb3e24d
ath10k: avoid possible memory access violation

array "ctl_power_table" access index "pream" is initialized with -1 and
is raised as a static analysis tool issue.
[drivers\net\wireless\ath\ath10k\wmi.c:4719] ->
[drivers\net\wireless\ath\ath10k\wmi.c:4730]: (error) Array index -1 is
out of bounds.

Since the "pream" index for accessing ctl_power_table array is initialized
with -1, there is a chance of memory access violation for the cases below.
1) wmi_pdev_tpc_final_table_event change frequency is between 2483 and 5180
2) pream_idx is out of the enumeration ranges of wmi_tpc_pream_2ghz,
wmi_tpc_pream_5ghz

Signed-off-by: K.T.VIJAYAKUMAAR <vijay.bvb@samsung.com>
[kvalo@codeaurora.org: clean up the warning message]
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
drivers/net/wireless/ath/ath10k/wmi.c